Fix aliases from jsconfig.json not being picked up anymore #5076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0016bbb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Oct 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Starting from 1.5.0, aliases inside
jsconfig.jsonwere not being properly picked up anymore, this fix that. The issue was that we were returning the originaltsconfig.jsonerror before checking for ajsconfig.jsonTesting
We can't test this! Since we first try for a
tsconfig.jsonbefore falling back tojsconfig.json, in the monorepo we always end up finding anothertsconfig.jsonup the filesystem (notably, the new one at root added by Nate after histsconfig.jsonadventures).jsconfig.jsonare.. kinda rare. All of our templates includestsconfig.json,astro addaddstsconfig.jsonetc. So I think it's not that bad for it to not be tested. Loading ajsconfig.jsondirectly however is testedDocs
N/A